Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test/unit/hook.spec.js #4288

Merged
merged 2 commits into from
May 14, 2020
Merged

fix test/unit/hook.spec.js #4288

merged 2 commits into from
May 14, 2020

Conversation

boneskull
Copy link
Contributor

Function.prototype.name is not available in IE11, and will cause the browser tests to fail.

Ideally, we could catch this with ESLint, but here's hoping we don't need to do that.

cc @nicojs

`Function.prototype.name` is not available in IE11, and will cause the browser tests to fail.
@boneskull boneskull added type: chore generally involving deps, tooling, configuration, etc. semver-patch implementation requires increase of "patch" version number; "bug fixes" labels May 13, 2020
@boneskull boneskull self-assigned this May 13, 2020
@boneskull
Copy link
Contributor Author

If you're wondering why this wasn't caught, it's because SauceLabs tests only run for branch commits; not PRs. Browser tests do get run for PRs--but only in headless Chrome.

@coveralls
Copy link

coveralls commented May 14, 2020

Coverage Status

Coverage increased (+0.009%) to 93.152% when pulling 885b525 on boneskull/chore/fix-build into 184036f on master.

@boneskull
Copy link
Contributor Author

also: Array.prototype.findIndex isn't a thing either

@boneskull boneskull merged commit 81e203c into master May 14, 2020
@boneskull boneskull deleted the boneskull/chore/fix-build branch May 14, 2020 19:23
@craigtaub craigtaub added this to the next milestone May 21, 2020
craigtaub pushed a commit that referenced this pull request May 21, 2020
* fix test/unit/hook.spec.js

`Function.prototype.name` is not available in IE11, and will cause the browser tests to fail.

* another IE11 fix: avoid Array.prototype.findIndex

Signed-off-by: Christopher Hiller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants