Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated methods #4178

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Remove deprecated methods #4178

merged 1 commit into from
Mar 12, 2020

Conversation

wnghdcjfe
Copy link
Contributor

Test environment

  • nodeVersion : v10.15.1
  • os : MacOS

Description of the Change

I removed deprecated Method and tested it. removing something is difficult like love but it is neccessery

  • Mocha.prototype.ignoreLeaks
  • Mocha.prototype.useColors
  • Mocha.prototype.useInlineDiffs
  • Mocha.prototype.hideDiff

Mocha.prototype.ignoreLeaks

Why it is be removed?
because Mocha.prototype.checkLeaks is Take on a role and do better

Testing result

After I removed, It is worked

index.html
<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8" />
    <title>Mocha Tests</title>
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <link rel="stylesheet" href="https://unpkg.com/mocha/mocha.css" />
  </head>
  <body>
    <div id="mocha"></div>
    <script src="https://unpkg.com/chai/chai.js"></script>
    <script src="./mocha.js"></script> 
    <script class="mocha-init">
      mocha.setup('bdd');
      mocha.checkLeaks();
    </script>

    <script src="./a.js"></script> 
    <script class="mocha-exec">
      mocha.run();
    </script>
  </body>
</html>
a.js
const expect = chai.expect;
describe('Leak detection', function() {
  const test = () => {
    a = 1; 
  } 
  it('should not leak', function() {
    test(); 
  }) 
})

Testing npm start build && cp mocha.js ../test/public/
And it is work!

Mocha.prototype.useColors

We use color() instead of useColors().
Not a base.js - exports.useColors I removed Mocha.js - Mocha.prototype.useColors

Testing result

After I removed, It is worked
node ../../mocha/bin/mocha a.js --color
node ../../mocha/bin/mocha a.js --no-color

Mocha.prototype.useInlineDiffs

We use inlinediff() instead of useInlineDiffs();
After I removed, It is worked
node ../../mocha/bin/mocha a.js --inline-diffs

a.js
const {expect} = require('chai');  
describe("actual & expected Test", function () { 
  it("should results is same to expected", function () { 
    const results = {
      depth: 2,
      foo: "bar"
    }; 
    const expected = {
      depth: 4,
      foo: "bar",
      hello: "world"
    }; 
    expect(results).to.deep.equal(expected);
  });
});

Mocha.prototype.hideDiff

We use diff() instead of hideDiff();
After I removed, It is worked
node ../../mocha/bin/mocha a.js --diff=false
node ../../mocha/bin/mocha a.js --diff

a.js
const {expect} = require('chai');  
describe("actual & expected Test", function () { 
  it("should results is same to expected", function () { 
    const results = {
      depth: 2,
      foo: "bar"
    }; 
    const expected = {
      depth: 4,
      foo: "bar",
      hello: "world"
    }; 
    expect(results).to.deep.equal(expected);
  });
});

Let me know if there is anything I couldn't check. I'll fix it.

Benefits

Clean up for next version.

@wnghdcjfe
Remove deprecated method
90fcd53 
Remove following methods and cleanup.
- Mocha.prototype.ignoreLeaks
- Mocha.prototype.useColors
- Mocha.prototype.useInlineDiffs
- Mocha.prototype.hideDiff
@wnghdcjfe wnghdcjfe changed the title Remove deprecated method Remove deprecated methods Feb 5, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 92.884% when pulling 90fcd53 on wnghdcjfe:gitmaster into 883ae4b on mochajs:master.

@juergba juergba added block semver-major implementation requires increase of "major" version number; "breaking changes" area: usability concerning user experience or interface labels Feb 5, 2020
@juergba juergba added this to the v8.0.0 milestone Feb 5, 2020
juergba
juergba approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wnghdcjfe thank you for this PR!

Mocha is not yet ready for a major release, so the merging into master can take some time. Therefore I set the label block.

@juergba juergba removed the block label Mar 12, 2020
@juergba juergba merged commit 6aeeb33 into mochajs:master Mar 12, 2020
@quincylvania quincylvania mentioned this pull request Jun 11, 2020
Closed
@CruzMolina CruzMolina mentioned this pull request Jul 6, 2020
Merged
@lhein lhein mentioned this pull request Jul 14, 2020
Merged
@sluukkonen sluukkonen mentioned this pull request Sep 3, 2020
Merged
8 tasks
@m90 m90 mentioned this pull request May 17, 2021
Merged
@andyleejordan andyleejordan mentioned this pull request May 21, 2021
Merged
@Tatsinnit Tatsinnit mentioned this pull request Dec 18, 2022
Merged
@mfranzke mfranzke mentioned this pull request Mar 12, 2023
Draft
76 tasks
@eugenet8k
Copy link
Contributor

We use inlinediff() instead of useInlineDiffs();

False, it is actually inlineDiffs

@Omrisnyk Omrisnyk mentioned this pull request Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juergba juergba juergba approved these changes

Assignees
No one assigned
Labels
area: usability concerning user experience or interface semver-major implementation requires increase of "major" version number; "breaking changes"
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wnghdcjfe @coveralls @eugenet8k @juergba