Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syntax highlighting on API site should use light color scheme #3664

Closed
boneskull opened this issue Jan 8, 2019 · 5 comments · Fixed by mochajs/mocha-docdash#3
Closed

syntax highlighting on API site should use light color scheme #3664

boneskull opened this issue Jan 8, 2019 · 5 comments · Fixed by mochajs/mocha-docdash#3
Labels
area: documentation anything involving docs or mochajs.org good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one!

Comments

@boneskull
Copy link
Contributor

It can be difficult (if not impossible) for colorblind people to read code on a dark background.

Use a color scheme with a light background. Feel free to adapt the scheme from mochajs.org.

static/styles/prettify.css is the file that needs modification.

You'll need to fork @mocha/docdash and send a PR there--not to this repo!
@boneskull boneskull added status: accepting prs Mocha can use your help with this one! area: documentation anything involving docs or mochajs.org good first issue new contributors should look here! labels Jan 8, 2019
@amanriquez
Copy link

Hello, I am a beginner looking for first issues. Are the item bars what you're talking about? like these:
https://mochajs.org/api/mocha#asyncOnly

@outsideris
Copy link
Contributor

I believe it is these kinds of code block.

@lqez
Copy link

lqez commented Feb 16, 2019

@boneskull I found a lot of light themes of code prettifier. Could you recommend a theme from https://jmblog.github.io/color-themes-for-google-code-prettify/?

@HyunSangHan HyunSangHan mentioned this issue Oct 3, 2019
Merged
@oussama-ber
Copy link

May I work on this?

@craigtaub
Copy link
Contributor

craigtaub commented Apr 27, 2020 •
edited
Loading

Sorry there is already an open PR @oussama-ber .

@craigtaub craigtaub mentioned this issue Apr 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: documentation anything involving docs or mochajs.org good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use light color scheme on Mocha API document HyunSangHan/mocha-docdash
6 participants
@outsideris @lqez @boneskull @craigtaub @amanriquez @oussama-ber