Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty default value in cli options #3433

Closed
outsideris opened this issue Jul 16, 2018 · 3 comments · Fixed by #3529
Closed

Empty default value in cli options #3433

outsideris opened this issue Jul 16, 2018 · 3 comments · Fixed by #3529
Labels
area: usability concerning user experience or interface

Comments

@outsideris
Copy link
Contributor 

--globals <names>                       allow the given comma-delimited global [names] (default: )

If default value is an empty list([]), it shows as (default: ). It is confusing to users. No default or (default: []) is better.
@outsideris outsideris added the area: usability concerning user experience or interface label Jul 16, 2018
@outsideris outsideris mentioned this issue Jul 16, 2018
Merged
@outsideris outsideris mentioned this issue Jul 26, 2018
Closed
@plroebuck plroebuck mentioned this issue Sep 2, 2018
Closed
@outsideris
Copy link
Contributor Author

If commander fix it and then a new version released, we can fix this.

@plroebuck
Copy link
Contributor

Hey, they finally released the fix in v2.19.0.

@outsideris
Copy link
Contributor Author

Good. I will fix this on it,

@outsideris outsideris mentioned this issue Oct 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: usability concerning user experience or interface
Projects
None yet
Milestone
No milestone
2 participants
@outsideris @plroebuck