-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve caching performance in CI #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default version is 9, currently. Signed-off-by: Christopher Hiller <[email protected]>
Signed-off-by: Christopher Hiller <[email protected]>
boneskull
added
qa
semver-patch
implementation requires increase of "patch" version number; "bug fixes"
labels
Apr 4, 2018
I'm going to go ahead and merge this because it seems to work. Mainly just wanted to explain myself. |
This was referenced Sep 22, 2018
Closed
Closed
This was referenced Oct 2, 2018
This was referenced Oct 25, 2018
This was referenced Nov 1, 2018
This was referenced Nov 19, 2018
This was referenced Dec 1, 2018
This was referenced Dec 8, 2018
This was referenced Dec 23, 2018
sgilroy
pushed a commit
to TwineHealth/mocha
that referenced
this pull request
Feb 27, 2019
* add precache stage to warm cache for jobs based default Node.js version * re-enable caching for node tests of v6 and v4 Signed-off-by: Christopher Hiller <[email protected]>
This was referenced Mar 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change "warms up" the npm caches for Node.js 9 jobs, since it will be reused during the build. It re-enables caching for Node.js 8, 6 and 4, since I RTFM'd more closely. 😬
From the Travis-CI docs:
node_modules
or~/.npm
, since it should always reflect what a user would get.npm install
for node.js 9 with no global environment variablesnode_modules
-only cache. these are not reused during the build (unlike the node 9 caches), but may be reused during subsequent builds against the same branch.