-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken Source Maps or Stack Traces for async functions after upgrading from 3.1.0 to 3.1.1 #2528
Comments
I'm going to guess this is Karma, karma-mocha, karma-babel-preprocessor and karma-phantomjs-launcher... but really could use some more info |
wait typescript? |
Yes to everything, except karma-babel-preprocessor ;) |
I can trivially reproduce with just karma, karma-mocha and karma-phantomjs-launcher (phantomjs 2.1.1) |
okay |
but not 100% that this is a bug yet |
okay, yeah this looks like a failure to properly handle the rejection. fwiw, the previous behavior was also incorrect, even though mocha was able to handle it. |
alright, I got something |
I have no idea what's causing the error to have a non-writable `stack` property. ¯\_(ツ)_/¯
I have no idea what's causing the error to have a non-writable `stack` property. ¯\_(ツ)_/¯
Cool! Thank you for the quick response. |
np. we don't have the greatest browser coverage, so this is bound to happen from time to time. published as v3.1.2 |
I have no idea what's causing the error to have a non-writable `stack` property. ¯\_(ツ)_/¯
Given a test like this:
3.1.1
shows:And also:
3.1.0
correctly reports an error with a correct stack trace and isn't disconnected from PhantomJS. (I guess the promise rejection is handled correctly.)Note that I use an
async
function here. (In my real test I alsoawait
something, but it is not necessary to do that to reproduce the error.Maybe it was introduced by fixing #1417?
The text was updated successfully, but these errors were encountered: