html reporter link to specific test is broken on some special characters

[amir-arad]

If the test title contains some special characters (for instance $ or () ) then its link in the HTML report does not work.

IMO the fix should be escaping regex here before calling encodeURIComponent(s)

[benvinegar]

I can reproduce the bug.

Digging deeper, the issue is caused because the grep query string argument is passed verbatim into the RegExp constructor, here:

if (query.grep) mocha.grep(new RegExp(query.grep));

Because the grep argument isn't escaped, it produces regex objects like:

/test that $.jQuery works/

Which of course don't work.

Patch incoming.

[benvinegar]

My bad. I had this backwards. --grep expects an escaped regex string ... so @amir-arad has it correctly.

[kevinbarabash]

I'm on an 1.21.4 and would like to upgrade. I tried upgrading to the current 2.2.5 and encountered this issue immediately b/c all of our tests have (version 4) to indicate the version of the build system. It makes it hard to investigate individual test failures.

[dasilvacontin]

@KevinB7, could you try @benvinegar's patch?