Add integration tests #1675
Merged
Add integration tests #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // before(function(done) { | ||
| // throw new Error('this hook should not be displayed'); | ||
| // }); | ||
|
|
There was a problem hiding this comment.
Found a bug here. Will open a new issue for this.
|
@mochajs/mocha :) Should help with CI. |
|
Wow, this is huge(and looks pretty good actually). |
|
And popcorn. 🎉 |
|
ping :) |
| * @param {function} fn | ||
| */ | ||
| runMochaJSON: function(fixturePath, args, fn) { | ||
| var path, args, output, mocha, listener; |
There was a problem hiding this comment.
output, mocha, listenerare unused- duplicate declaration of
args
|
LGTM! |
| sleep(2); | ||
| done(); | ||
| }); | ||
|
|
||
| function sleep(ms){ | ||
| function sleep(ms) { | ||
| var start = Date.now(); | ||
| while(start + ms > Date.now())continue; |
There was a problem hiding this comment.
This continue is unnecessary here(because this loop doesn't have a body)
|
Done! I was thinking I'd merge this evening unless someone else has some recommendations. cc @mochajs/owners |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few tests (acceptance, regression, etc) require either manual invocation or visual confirmation after running the test suite to confirm their success or failure. This PR updates some of those to use a helper that invokes mocha and verifies its output. Parts were extracted/modified from #1618
Edit: For clarification. This mostly deals with test files that previously were never ran (had to be manually done), or which required close watch of the test results and console output, as their failure wouldn't trigger a failing build.