Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery dependency #158

Closed
rauchg opened this issue Dec 18, 2011 · 5 comments
Closed

Remove jQuery dependency #158

rauchg opened this issue Dec 18, 2011 · 5 comments
Labels
area: browser browser-specific

Comments

@rauchg
Copy link
Contributor

rauchg commented Dec 18, 2011

No description provided.

@jprichardson
Copy link

@Raynos what's wrong with using querySelector?

@Raynos
Copy link
Contributor

Raynos commented Jan 23, 2012

@jprichardson doesn't work in legacy browsers. That and it's simply slower then gEBTN. The latter is faster and has better browser support so win/win.

Also note that the bulk of the jQuery removal fix was done in the other commit I made. Removing qs was just a minor tweak I made to that commit.

@rwaldron
Copy link

@Raynos ...

@jprichardson doesn't work in legacy browsers.

That argument doesn't hold when you haven't replaced the use of canvas...

@rauchg
Copy link
Contributor Author

rauchg commented Jan 30, 2012

The canvas is just a fancy addition though. We don't need to have that for unfancy browsers.
If I remember correctly I was doing a check for the existence of getContext, so it shouldn't break.

@rwaldron
Copy link

True enough. Strike last comment

@tj tj closed this as completed in 71f3962 Apr 13, 2012
domenic pushed a commit to domenic/mocha that referenced this issue Apr 13, 2012
Fixes mochajs#158: removes jquery include from browser tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: browser browser-specific
Projects
None yet
Development

No branches or pull requests

5 participants