Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'after' not being called on failure #143

Closed
pofallon opened this issue Dec 13, 2011 · 4 comments
Closed

'after' not being called on failure #143

pofallon opened this issue Dec 13, 2011 · 4 comments

Comments

@pofallon
Copy link

Issue #125 appears to have addressed afterEach, but I'm seeing 'after' only called on success, not on failure.

@tj
Copy link
Contributor

tj commented Dec 14, 2011

works for me:


  test
.after each
after


  ✖ 1 of 1 tests failed:

  0) something should foo:
     Error: fail

@pofallon
Copy link
Author

I created a simple example here: https://gist.github.com/1477732

In creating this example I realized that it only happens when the test fails inside a callback.

@tj
Copy link
Contributor

tj commented Dec 14, 2011

ah right right, this is actually a different issue of the uncaught exceptions ending the tests right away

@pofallon
Copy link
Author

Agreed - good point. I imagine that makes this a duplicate of #94 so I'll close is one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants