Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mocha.run() never return error status on browser #1216

Merged
merged 1 commit into from
May 16, 2014
Merged

Conversation

nopnop
Copy link
Contributor

@nopnop nopnop commented May 16, 2014

Mocha.prototype.run([callback]) provide an error status to the callback (0/1).
But this value is not forwarded to the browser callback.

Example:

mocha.run(function(err) {
  console.log(err); // Always undefined
})

Mocha.prototype.run(callback) provide an error status to the callback (0/1).
But this value is not forwarded to the browser callback.

    mocha.run(function(err) {
      console.log(err); // Always undefined
    })
tj added a commit that referenced this pull request May 16, 2014
mocha.run() never return error status on browser
@tj tj merged commit ef12ff4 into mochajs:master May 16, 2014
@nopnop
Copy link
Contributor Author

nopnop commented May 19, 2014

Thanks.
Maybe you forgot to re-compile the browser version in the last release (1.19.0) so the issue remain unfixed.
(I could have provide a compiled version of browser.js in my PR, but I thought it was not a good practice: Was I wrong ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants