Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 950 - Export file on Mocha.Test objects #1174

Merged
merged 1 commit into from
Mar 28, 2014
Merged

Conversation

lambdabaa
Copy link

This patch exposes a file property on Test objects. I've gone ahead and added a reporter that proves that the patch works. Running the mocha test suite with |REPORTER=file make test| prints

/home/gareth/Documents/mocha/test/hook.timeout.js => 1 tests
/home/gareth/Documents/mocha/test/acceptance/context.js => 1 tests
/home/gareth/Documents/mocha/test/acceptance/diffs.js => 9 tests
/home/gareth/Documents/mocha/test/acceptance/duration.js => 3 tests
/home/gareth/Documents/mocha/test/acceptance/fs.js => 2 tests
/home/gareth/Documents/mocha/test/acceptance/globals.js => 4 tests
/home/gareth/Documents/mocha/test/acceptance/http.js => 1 tests
/home/gareth/Documents/mocha/test/acceptance/multiple.done.js => 1 tests
/home/gareth/Documents/mocha/test/acceptance/pending.js => 1 tests
/home/gareth/Documents/mocha/test/acceptance/required-tokens.js => 1 tests
/home/gareth/Documents/mocha/test/acceptance/root.js => 1 tests
/home/gareth/Documents/mocha/test/acceptance/timeout.js => 2 tests
/home/gareth/Documents/mocha/test/acceptance/uncaught.js => 1 tests
/home/gareth/Documents/mocha/test/acceptance/utils.js => 5 tests
/home/gareth/Documents/mocha/test/grep.js => 6 tests
/home/gareth/Documents/mocha/test/hook.async.js => 3 tests
/home/gareth/Documents/mocha/test/hook.err.js => 21 tests
/home/gareth/Documents/mocha/test/hook.sync.js => 3 tests
/home/gareth/Documents/mocha/test/hook.sync.nested.js => 4 tests
/home/gareth/Documents/mocha/test/http.meta.2.js => 3 tests
/home/gareth/Documents/mocha/test/http.meta.js => 3 tests
/home/gareth/Documents/mocha/test/runnable.js => 21 tests
/home/gareth/Documents/mocha/test/runner.js => 21 tests
/home/gareth/Documents/mocha/test/suite.js => 36 tests
/home/gareth/Documents/mocha/test/utils.js => 3 tests

This patch fixes #950.

@tj
Copy link
Contributor

tj commented Mar 27, 2014

LGTM but we should remove the reporter, that can stay in npm there's no way it would be common enough for core

@lambdabaa
Copy link
Author

All gone!

@lambdabaa
Copy link
Author

And yeah it was more just to exercise the code path ;)

@lambdabaa
Copy link
Author

Test failure seems unrelated to patch?

@lambdabaa
Copy link
Author

@visionmedia ping is this good to go?

tj added a commit that referenced this pull request Mar 28, 2014
Issue 950 - Export file on Mocha.Test objects
@tj tj merged commit 64396af into mochajs:master Mar 28, 2014
@evanxd
Copy link

evanxd commented Mar 31, 2014

++

@lambdabaa
Copy link
Author

@visionmedia @travisjeffery Would you mind publishing a new version in npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filename to Mocha.Test objects
3 participants