lib: errno is not a global in node >= v0.9.11 #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the global leak checker to add errno to the list of expected globals only when the node version is < v0.9.11.
travisjeffery
added a commit
that referenced
this pull request
Jan 18, 2014
lib: errno is not a global in node >= v0.9.11 * bnoordhuis/report-errno-global-leaks: lib: errno is not a global in node >= v0.9.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the global leak checker to add errno to the list of expected
globals only when the node version is < v0.9.11.
I'd like to add a regression test but I'm not sure how to go about it. I've seen test/acceptance/globals.js but there doesn't seem to be a way to make it work with conditional failures.