Runner.prototype.globals refactor #1024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of doing a verbose `.forEach` with `this.globals.push`, it should just use `this.globals = this.globals.concat` which is optimized by V8’s JIT compiler.
|
cool, wrong spot for the change tho. mocha.js is compiled from the real src files. |
|
That would explain why I was editing a ~4000 line file…But also, why keep |
|
haha that's not really worth even arguing about :p shaving a few bytes means nothing |
|
@visionmedia I see you wrote the original code from my blaming… Why would you loop over an array just to push each item to another array? Did you forget your coffee that day? |
|
I don't remember why that's there, not a huge deal either way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing a verbose
.forEachwiththis.globals.push, it should just usethis.globals = this.globals.concatwhich is optimized by V8’s JIT compiler.