Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaking task resources when nodes are deleted #2806

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Fix leaking task resources when nodes are deleted #2806

merged 1 commit into from
Mar 21, 2019

Commits on Jan 14, 2019

  1. Fix leaking task resources when nodes are deleted 

    When a node is deleted, its tasks are asked to restart, which involves
putting them into a desired state of Shutdown. However, the Allocator
will not deallocate a task which is not in an actual state of a terminal
state. Once a node is deleted, the only opportunity for its tasks to
recieve updates and be moved to a terminal state is when the function
moving those tasks to TaskStateOrphaned is called, 24 hours after the
node enters the Down state. However, if a leadership change occurs, then
that function will never be called, and the tasks will never be moved to
a terminal state, leaking resources.

With this change, upon node deletion, all of its tasks will be moved to
TaskStateOrphaned, allowing those tasks' resources to be cleaned up.

Signed-off-by: Drew Erny <[email protected]>
    @dperny
    dperny committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    8467e6a View commit details
    Browse the repository at this point in the history