scheduler: Fix accounting when task ends up in multiple groups #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #2031 +/- ##
==========================================
- Coverage 53.74% 53.66% -0.09%
==========================================
Files 109 109
Lines 19194 19193 -1
==========================================
- Hits 10316 10300 -16
- Misses 7631 7640 +9
- Partials 1247 1253 +6Continue to review full report at Codecov.
|
Tasks are split between task groups based on common specs. This allows nodes to only be ranked once per group, not once per task. This logic doesn't work correctly because maps are marshalled in a random order. Currently, the same task can end up in a multiple groups (say, if it's updated multiple times, and the marshalling ends up being different). To make sure we don't try to schedule the same task twice within the same batch, use a map for unassignedTasks instead of a linked list. Note this doesn't fix the brokenness of task spec deduplication based on marshalling the protobuf. This is a fix for the symptom that can be backported, and I'm going to replace the marshalling stuff in a different PR. Signed-off-by: Aaron Lehmann <[email protected]>
aaronlehmann
force-pushed
the
scheduler-resource-accounting
branch
from
281c31e to
83d3652
Compare
|
I've changed this to make |
|
LGTM |
Merged
This was referenced Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks are split between task groups based on common specs. This allows
nodes to only be ranked once per group, not once per task.
This logic doesn't work correctly because maps are marshalled in a
random order. Currently, the same task can end up in a multiple groups
(say, if it's updated multiple times, and the marshalling ends up being
different). To make sure we don't try to schedule the same task twice
within the same batch, use a map for unassignedTasks instead of a linked
list.
Note this doesn't fix the brokenness of task spec deduplication based on
marshalling the protobuf. This is a fix for the symptom that can be
backported, and I'm going to replace the marshalling stuff in a
different PR.
cc @aluzzardi @dongluochen