Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect against wedged managers #1658

Closed
aaronlehmann opened this issue Oct 18, 2016 · 0 comments
Closed

Protect against wedged managers #1658

aaronlehmann opened this issue Oct 18, 2016 · 0 comments

Comments

@aaronlehmann
Copy link
Collaborator

If a manager gets stuck with the store lock held (for example, as in #1651), this does not affect heartbeats, and there won't be a new leader election. It's a very bad failure mode because you end up with a stuck leader that doesn't get replaced. We should consider ways to reduce the impact of this situation.

Perhaps the leader should stop sending heartbeats if the store lock has been held for too long?

Or perhaps other managers should periodically poll a noop RPC endpoint on the leader that takes the store lock, and start a leader election if it times out?

cc @aluzzardi @LK4D4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant