-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give hostname and domain to drivers #234
Comments
If there is a "service model" interpretation then that is fine -- we're not hung up on using hostnames specifically. |
Actually having had a better look at the docker integration, I see that they are included in the join options, so perhaps this issue is redundant. |
(sorry, wrong button; but please close if you think this issue is already addressed) |
No it's not redundant, those only set fields in the container config, and don't get given to the driver. |
I've made a small, ragged patch in my own fork of docker, that supplies these as generic options on the CreateEndpoint call; but only for endpoints created as part of I'll need to rejig it to fit with moby/moby#13441. |
@squaremo It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:
Thank you! |
In weave "classic" we register containers that have a weave IP and a hostname with DNS, so they can be looked up across the weave network. In the libnetwork driver model, the driver is told neither the container ID nor the hostname, so this feature is not viable.
I'm not sure what the preferred means would be; but being given the hostname and domain when say, creating an endpoint, could make DNS registration possible again.
The text was updated successfully, but these errors were encountered: