Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give hostname and domain to drivers #234

Closed
squaremo opened this issue May 29, 2015 · 7 comments
Closed

Give hostname and domain to drivers #234

squaremo opened this issue May 29, 2015 · 7 comments

Comments

@squaremo
Copy link
Contributor

In weave "classic" we register containers that have a weave IP and a hostname with DNS, so they can be looked up across the weave network. In the libnetwork driver model, the driver is told neither the container ID nor the hostname, so this feature is not viable.

I'm not sure what the preferred means would be; but being given the hostname and domain when say, creating an endpoint, could make DNS registration possible again.

@squaremo
Copy link
Contributor Author

If there is a "service model" interpretation then that is fine -- we're not hung up on using hostnames specifically.

@squaremo
Copy link
Contributor Author

squaremo commented Jun 2, 2015

@mavenugo @mrjana Any comments? There are workarounds for this, but they are, frankly, horrific -- they involve remembering state gleaned from the docker event stream and correlating it with CreateEndpoint/Join calls. It would be better to just be told the information when it is pertinent.

@squaremo
Copy link
Contributor Author

squaremo commented Jun 2, 2015

Actually having had a better look at the docker integration, I see that they are included in the join options, so perhaps this issue is redundant.

@squaremo squaremo closed this as completed Jun 2, 2015
@squaremo squaremo reopened this Jun 2, 2015
@squaremo
Copy link
Contributor Author

squaremo commented Jun 2, 2015

(sorry, wrong button; but please close if you think this issue is already addressed)

@squaremo
Copy link
Contributor Author

squaremo commented Jun 2, 2015

I see that they are included in the join options, so perhaps this issue is redundant.

No it's not redundant, those only set fields in the container config, and don't get given to the driver.

@squaremo
Copy link
Contributor Author

squaremo commented Jun 4, 2015

I've made a small, ragged patch in my own fork of docker, that supplies these as generic options on the CreateEndpoint call; but only for endpoints created as part of docker run --net=.... This is on the assumption that those endpoints are for "simple networking", rather than participating in the upcoming service discovery abstraction. (squaremo/docker@8014c31)

I'll need to rejig it to fit with moby/moby#13441.

@GordonTheTurtle
Copy link

@squaremo It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:

  • For a bug: do you still experience the issue with the latest version?
  • For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to #1926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants