Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PortAllocator redesign #169

Closed
mavenugo opened this issue May 18, 2015 · 2 comments
Closed

PortAllocator redesign #169

mavenugo opened this issue May 18, 2015 · 2 comments

Comments

@mavenugo
Copy link
Contributor

Port Allocator is supposed to be a reflection of the Operating System construct and must be in sync with OS view of the allocated ports.

The current port allocator reflects the software db of that construct.
Also, port allocator must also provide allocation for individual network namespace and not just for the global space.

@ghost
Copy link

ghost commented May 23, 2015

In case host OS does a change in the port allocation which might affect the underlying containers what is the workflow? Docker daemon monitors such changes and via libnetwork will inform the underlying containers or ?

@akerouanton
Copy link
Member

With the recent changes made in Docker v27.0, libnetwork now bind sockets before inserting iptables rules. That way, libnetwork alone doesn't determine whether a port is free.

Although the PortAllocator wasn't redesigned (it's still used to iterate on known-bound ports), I think that covers what this ticket was up for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants