Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename service under libnetwork/client to endpoint to avoid confusion #1660

Closed
huikang opened this issue Feb 22, 2017 · 5 comments
Closed

Rename service under libnetwork/client to endpoint to avoid confusion #1660

huikang opened this issue Feb 22, 2017 · 5 comments

Comments

@huikang
Copy link
Contributor

huikang commented Feb 22, 2017

The libnetwork/client package provides the service subcommand so that libnetwork supports the command like ./dnet service publish | attach. After reading the document, I feel that the service here really means an endpoint. To avoid the confusion with service in swarmkit or other things in libnetwork such as LB and FW [1], how about renaming service under libnetwork/client to endpoint?

@aboch
Copy link
Contributor

aboch commented Feb 22, 2017

I feel that the service here really means an endpoint

@huikang That is correct.

The libnetwork/api was added at the time the network endpoint was meant to carrying the service concept. And libnetwork was thought to also be used as an independent binary (see dnet) and programmed via those apis.

This is no longer the case.

But the dnet and libnetwork/api were kept as the integration tests can be achieved by using them without dependency on docker.

@huikang
Copy link
Contributor Author

huikang commented Feb 22, 2017

@aboch Thanks for clarifying this. It takes a while for me to identify that difference between service in dnet and service in docker engine. I agree that libnetwork/api and dnet should be kept to make libnetwork independent of docker.

If you think this renaming proposal is a valid change, I am glad to spend some time working on this. Please let me know. Thanks.

@GordonTheTurtle
Copy link

@huikang It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:

  • For a bug: do you still experience the issue with the latest version?
  • For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to #1926

2 similar comments
@GordonTheTurtle
Copy link

@huikang It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:

  • For a bug: do you still experience the issue with the latest version?
  • For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to #1926

@GordonTheTurtle
Copy link

@huikang It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:

  • For a bug: do you still experience the issue with the latest version?
  • For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to #1926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants