-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename service under libnetwork/client to endpoint to avoid confusion #1660
Comments
@huikang That is correct. The libnetwork/api was added at the time the network endpoint was meant to carrying the service concept. And libnetwork was thought to also be used as an independent binary (see This is no longer the case. But the dnet and libnetwork/api were kept as the integration tests can be achieved by using them without dependency on docker. |
@aboch Thanks for clarifying this. It takes a while for me to identify that difference between If you think this renaming proposal is a valid change, I am glad to spend some time working on this. Please let me know. Thanks. |
@huikang It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:
Thank you! |
2 similar comments
@huikang It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:
Thank you! |
@huikang It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:
Thank you! |
The
libnetwork/client
package provides theservice
subcommand so that libnetwork supports the command like./dnet service publish | attach
. After reading the document, I feel that theservice
here really means an endpoint. To avoid the confusion with service in swarmkit or other things in libnetwork such as LB and FW [1], how about renaming service under libnetwork/client to endpoint?The text was updated successfully, but these errors were encountered: