How to use HTTP header with ADD command

[ORESoftware]

In light of the Github API changes:
https://developer.github.com/changes/2/ (https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/)

this won't really work in the near future:

ARG token
ADD "<url>?access_token=$token"  .

instead we are gonna have to do:

RUN curl -H "Authorization: token $token" "url"  >  bar

is there a way to use a header with ADD or should we just use curl?

[thaJeztah]

@tonistiigi @AkihiroSuda ptal

[AkihiroSuda]

I suggest using RUN --mount=type=secret curl

[ORESoftware]

@AkihiroSuda umm what is that? can you link to docs so other people can find it easily?

[AkihiroSuda]

https://docs.docker.com/develop/develop-images/build_enhancements/#new-docker-build-secret-information

$ docker build --secret id=token,src=token.txt ...

Dockerfile:

# syntax = docker/dockerfile:1-experimental
FROM ...
...
RUN --mount=type=secret,id=token,dst=/token.txt \
  curl -H "Authorization: token $(cat /token.txt)" ...

[ORESoftware]

right but we can use a multi-stage build to get rid of the secrets or whatever, this issue is more about how to ADD with http headers instead of just a url, something like:

ADD --headers <url>  '.'

[thaJeztah]

Let me transfer this ticket to the BuildKit issue tracker, which is where the Dockerfile syntax is now maintained.