Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[discuss] naming for errdefs.ContainerdUnknownExitStatus const #1811

Closed
thaJeztah opened this issue Nov 18, 2020 · 0 comments · Fixed by #1830
Closed

[discuss] naming for errdefs.ContainerdUnknownExitStatus const #1811

thaJeztah opened this issue Nov 18, 2020 · 0 comments · Fixed by #1830
Assignees
@coryb

Comments

@thaJeztah
Copy link
Member

Per the discussion on #1808

Let me know if the current place for this const looks good to you (happy to move it elsewhere; mostly looked for a package that seemed related; initially had it in https://github.com/moby/buildkit/blob/bec28f9d5b0e8f610b682b46d06018d3134793b5/util/grpcerrors/grpcerrors.go)

Follow up if want to move to a better place. Not sure if Containerd prefix is correct as well.

Opening a tracking issue to discuss naming and/or location for this variable

@tonistiigi @tiborvass let me know if you have suggestions 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryb coryb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move UnknownExitStatus to executor package from errdefs coryb/buildkit
2 participants
@coryb @thaJeztah