Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of contribution flow. #2098

Closed
1 of 4 tasks
damianprzygodzki opened this issue Sep 6, 2019 · 2 comments
Closed
1 of 4 tasks

Improvement of contribution flow. #2098

damianprzygodzki opened this issue Sep 6, 2019 · 2 comments

Comments

@damianprzygodzki
Copy link

damianprzygodzki commented Sep 6, 2019

Welcome to MobX. Please provide as much relevant information as possible!

I have a:

  1. Idea:
  • What problem would it solve for you?
    I wanted to improve docs because deprecation of passing stores directly should be featured in documentation. You are asking in issue template to instead of that, create a PR. Ok! Great. But where i can find docs? Found some PR about docs, to another branch. Wait what? Docs are other branch with totally different files structure? I wouldn't expect that...
  • Do you think others will benefit from this change as well and it should in core package (see also mobx-utils)?
    Of course, anyone who is beginning a journey with Mobx firstly sees egghead clip where is shown deprecated code.
  • Are you willing to (attempt) a PR yourself?
    If there would be straightforward information how to deal with this weird docs location...
@danielkcz
Copy link
Contributor

danielkcz commented Sep 6, 2019

@damianprzygodzki Yea, docs contributing is rather cumbersome and done through gh-pages branch and Gitbook as the underlying tool. There were already attempts to improve that (#1859), but it never went through.

I will close this as it's more of the duplicate of #1859. In case, you would feel up to the task, feel free for sure :) Any follow-up questions into that issue, please.

@lock
Copy link

lock bot commented Nov 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants