types.map shows error when using types.number in identifier subtype

[boatkorachal]

const { types } = require("mobx-state-tree")

const Todo = types.model("Todo", {
    todo_id: types.identifier(types.number),
    title: types.string,
})

const TodoStore = types.model("TodoStore", {
  todos: types.optional(types.map(Todo), {}),
}, {
  addTodo(todo) {
    this.todos.put(todo)
  },
})

const todoStore = TodoStore.create({})

todoStore.addTodo({
  todo_id: 1,
  title: "Test",
})

It shows

Error: [mobx-state-tree] A map of objects containing an identifier should always store the object under their own identifier. Trying to store key '1', but expected: '1'

But when I use types.string as identifier, it's ok

[mattiamanzati]

Hi! Thanks for reporting!
Can you please try to clone, build and install the master branch from the repository and check if it fixes your problem? :)

[boatkorachal]

Yes! It fix now
Thanks! :)

But I found another bug when I put the same identifier on map.

const Todo = types.model("Todo", {
    todo_id: types.identifier(types.number),
    title: types.string,
})

const TodoStore = types.model("TodoStore", {
  todos: types.optional(types.map(Todo), {}),
}, {
  addTodo(todo) {
    this.todos.put(todo)
  },
})

const todoStore = TodoStore.create({})

todoStore.addTodo({
  todo_id: 1,
  title: "Test",
})

console.log(todoStore.todos.toJSON())
// PRINT: { '1': { todo_id: 1, title: 'Test' } }

todoStore.addTodo({
  todo_id: 1,
  title: "Test Edited",
})

console.log(todoStore.todos.toJSON())
// PRINT: { '': { todo_id: 1, title: 'Test Edited' } }  <-- it shows the key is empty string

console.log(todoStore.todos.get(1).toJSON())
// PRINT: { todo_id: 1, title: 'Test Edited' } <-- but it can get the model that i put

[mattiamanzati]

Thanks for reporting again! :)
Can you please update from the master and check if it's fixed? :)

[boatkorachal]

Yes! It's fixed now
Thank you very much :)

[mattiamanzati]

You're welcome! Will be released soon!