Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial English fixes #73

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Trivial English fixes #73

merged 1 commit into from
Mar 29, 2021

Conversation

ujihisa
Copy link
Contributor

@ujihisa ujihisa commented Mar 29, 2021

No description provided.

Copy link
Member

@kachick kachick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your first contribution 👍
I think this is generated by create-react-app https://github.com/facebook/create-react-app/blob/7e4949a20fc828577fb7626a3262832422f3ae3b/packages/cra-template-typescript/template/README.md

So how do you think to create PR for the original project? 😄

@kachick kachick requested a review from pankona March 29, 2021 14:35
@pankona
Copy link
Member

pankona commented Mar 29, 2021

Sweet changes! Thanks! @ujihisa

@pankona pankona merged commit c30f59a into mobu-of-the-world:main Mar 29, 2021
@ujihisa ujihisa deleted the patch-1 branch March 29, 2021 23:29
@ujihisa
Copy link
Contributor Author

ujihisa commented Mar 31, 2021

So how do you think to create PR for the original project? 😄

Done
facebook/create-react-app#10763

@kachick
Copy link
Member

kachick commented Apr 1, 2021

Oh it is great work! You saved a lot of people from this issue! And this PR is the origin of the fix. It is honored for mobber as me 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants