Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Remove pytorch from the project requirements #3

Closed
oobabooga opened this issue Dec 20, 2023 · 2 comments
Closed

[Request] Remove pytorch from the project requirements #3

oobabooga opened this issue Dec 20, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@oobabooga
Copy link

oobabooga commented Dec 20, 2023

PyTorch cannot be effectively managed through a requirements.txt due to the need for specific channels.

After adding the hqq requirement to text-generation-webui, unwanted pytorch updates happened after pip install -r requirements.txt: oobabooga/text-generation-webui#4993. For this reason I had to remove hqq from the requirements.

I think that it would be best to remove PyTorch from

hqq/setup.py

Line 12 in bb422c9

install_requires=['numpy>=1.24.4','tqdm>=4.64.1', 'torch>=2.1.1', 'huggingface_hub', 'accelerate', 'timm', 'transformers>=4.36.1', 'termcolor'], #add vllm/langchain?
and just mention the minimum PyTorch version in the README, or at least not specify the minimum version.

@mobicham
Copy link
Collaborator

@oobabooga sure, it makes sense to remove it because it also causes problems with CUDA versions and VLLM.
Can you try now? pip should install 0.1.1.post1 which doesn't include Pytorch in the dependencies.

@oobabooga
Copy link
Author

That seems to have done the trick, thank you :) oobabooga/text-generation-webui@f0f6d9b

@mobicham mobicham added the enhancement New feature or request label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants