Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl ConstantTimeFoo on quote types #280

Open
1 task
nick-mobilecoin opened this issue Feb 24, 2023 · 0 comments
Open
1 task

Impl ConstantTimeFoo on quote types #280

nick-mobilecoin opened this issue Feb 24, 2023 · 0 comments
Assignees
@varsha888

Comments

@nick-mobilecoin
Copy link
Collaborator

nick-mobilecoin commented Feb 24, 2023 •
edited by varsha888
Loading

Comment from mobilecoinfoundation/attestation#3 (comment)

I'd say we should just impl ConstantTimeEq for Attributes in core-types, honestly.

We probably need to implement all of the Ct traits, from mobilecoinfoundation/attestation#18 (comment)

ConfigSvn doesn't implement ConstantTimeEq and ConstantTimeGreater, so the as_ref() gets to the underlying u16
@nick-mobilecoin nick-mobilecoin mentioned this issue Feb 24, 2023
Merged
This was referenced Feb 27, 2023
Closed
Closed
Open
Merged
Merged
@jcape jcape changed the title Impl ConstantTimeEq on quote types Impl ConstantTimeFoo on quote types Mar 2, 2023
@jcape jcape moved this from Todo to In Progress in Blockchain Core Mar 10, 2023
@varsha888 varsha888 mentioned this issue Mar 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varsha888 varsha888

Labels
None yet
Projects
Blockchain Core
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ConstantTimeEq proc macro derive mobilecoinfoundation/sgx
2 participants
@nick-mobilecoin @varsha888