Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gift Code Memo Builder #1933

Merged
merged 12 commits into from
May 19, 2022
Merged

Gift Code Memo Builder #1933

merged 12 commits into from
May 19, 2022

Commits on May 13, 2022

  1. Refactor memo builder into separate memo builders

    @iamalwaysuncomfortable
    iamalwaysuncomfortable committed May 13, 2022
    Configuration menu
    Copy the full SHA
    6eee02b View commit details
    Browse the repository at this point in the history

  2. Lint fix

    @iamalwaysuncomfortable
    iamalwaysuncomfortable committed May 13, 2022
    Configuration menu
    Copy the full SHA
    bc52679 View commit details
    Browse the repository at this point in the history

  3. Lint fix part deux

    @iamalwaysuncomfortable
    iamalwaysuncomfortable committed May 13, 2022
    Configuration menu
    Copy the full SHA
    fa8705a View commit details
    Browse the repository at this point in the history

Commits on May 14, 2022

  1. Test coverage for cancellation and sender memo builder

    @iamalwaysuncomfortable
    iamalwaysuncomfortable committed May 14, 2022
    Configuration menu
    Copy the full SHA
    acfb5c7 View commit details
    Browse the repository at this point in the history

  2. Address sorting & comment structure nits

    @iamalwaysuncomfortable
    iamalwaysuncomfortable committed May 14, 2022
    Configuration menu
    Copy the full SHA
    5726252 View commit details
    Browse the repository at this point in the history

  3. Add even more tests

    @iamalwaysuncomfortable
    iamalwaysuncomfortable committed May 14, 2022
    Configuration menu
    Copy the full SHA
    49b2819 View commit details
    Browse the repository at this point in the history

  4. Small comment fixes

    @iamalwaysuncomfortable
    iamalwaysuncomfortable committed May 14, 2022
    Configuration menu
    Copy the full SHA
    70ce48b View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. Remove zero value restrictions, allow empty destination memos on canc… 

    …ellation/funding
    @iamalwaysuncomfortable
    iamalwaysuncomfortable committed May 16, 2022
    Configuration menu
    Copy the full SHA
    69143fd View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. Add transaction builder test for gift code flow + remove default patt… 

    …ern for memo builder in favor of new()

The data needed to create the memo builders should only need to be initialized once. Doing
so removes the room for error and in some cases, is necessary at initialization. Additionally
tests of a simulated gift code funding & redemption flow were added.
    @iamalwaysuncomfortable
    iamalwaysuncomfortable committed May 18, 2022
    Configuration menu
    Copy the full SHA
    cac8cf9 View commit details
    Browse the repository at this point in the history

  2. Lint fix

    @iamalwaysuncomfortable
    iamalwaysuncomfortable committed May 18, 2022
    Configuration menu
    Copy the full SHA
    5557cda View commit details
    Browse the repository at this point in the history

  3. Comment clarifications

    @iamalwaysuncomfortable
    iamalwaysuncomfortable committed May 18, 2022
    Configuration menu
    Copy the full SHA
    29e3e11 View commit details
    Browse the repository at this point in the history

  4. Code cleanup suggestions

    @iamalwaysuncomfortable
    iamalwaysuncomfortable committed May 18, 2022
    Configuration menu
    Copy the full SHA
    16352f7 View commit details
    Browse the repository at this point in the history