Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inputText sometimes repeats individual characters #2005

Open
1 task done
bartekpacia opened this issue Sep 2, 2024 · 3 comments · May be fixed by #2027
Open
1 task done

inputText sometimes repeats individual characters #2005

bartekpacia opened this issue Sep 2, 2024 · 3 comments · May be fixed by #2027
Labels
bug Something isn't working maestro cli Related to the command-line Maestro tool P1 Important, valid issues at the top of the work list platform: android Testing Android apps is affected

Comments

@bartekpacia
Copy link
Contributor

bartekpacia commented Sep 2, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues and didn't find mine.

Steps to reproduce

This is a flake. It sometimes occur in our E2E action.

Actual results

Sometimes individual characters are repeated.

So far I noticed a few occurences of this:

Expected results

inputText always inputs expactly the text specified.

About app

It's our demo_app.

About environment

The environment on our GitHub Action.

We run tests on Android emulator, v28.

It's unknown at this time if this issue also occurs on iOS.

Logs

Logs 
<!-- Replace this line with your logs. *DO NOT* remove the backticks! -->

Maestro version

1.38.1

How did you install Maestro?

install script (https://get.maestro.mobile.dev)

Anything else?

No response
@bartekpacia bartekpacia added bug Something isn't working maestro cli Related to the command-line Maestro tool P1 Important, valid issues at the top of the work list platform: android Testing Android apps is affected labels Sep 2, 2024
This was referenced Sep 2, 2024
Merged
Merged
Open
Merged
Merged
Merged
@tokou
Copy link
Contributor

tokou commented Sep 3, 2024

FYI @bartekpacia we experience a lot of those in our flows. We had to resort to stuff like this to try and make tests less flaky

- inputText: 'H'
- inputText: 'e'
- inputText: 'l'
- inputText: 'l'
- inputText: 'o'

@bartekpacia
Copy link
Contributor Author

Offending code:

maestro/maestro-android/src/androidTest/java/dev/mobile/maestro/MaestroDriverService.kt

Lines 287 to 303 in d87b815

override fun inputText(
request: MaestroAndroid.InputTextRequest,
responseObserver: StreamObserver<MaestroAndroid.InputTextResponse>
) {
try {
Log.d("Maestro", "Inputting text")
request.text.forEach {
setText(it.toString())
Thread.sleep(75)
}
responseObserver.onNext(inputTextResponse { })
responseObserver.onCompleted()
} catch (e: Throwable) {
responseObserver.onError(e.internalError())
}
}

@bartekpacia bartekpacia mentioned this issue Sep 6, 2024
Open
@tokou tokou linked a pull request Sep 7, 2024 that will close this issue
Open
This was referenced Sep 9, 2024
Closed
Open
Merged
@tokou
Copy link
Contributor

tokou commented Sep 16, 2024

Linked #1667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working maestro cli Related to the command-line Maestro tool P1 Important, valid issues at the top of the work list platform: android Testing Android apps is affected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix input text speed on Android tokou/maestro
2 participants
@tokou @bartekpacia