Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Language Translations for Day Names for non-English locales #14

Closed
mobeigi opened this issue Jul 28, 2019 · 1 comment
Closed

Add Language Translations for Day Names for non-English locales #14

mobeigi opened this issue Jul 28, 2019 · 1 comment
Labels
bug Something isn't working
Milestone
1.0.3

Comments

@mobeigi
Copy link
Owner

mobeigi commented Jul 28, 2019

See #11 for context.

All non-English locales need day name translations to properly work out the close/relative dates.

Possible approaches:

  • Hardcode all translations for every non-English locale
  • Use Google Translate API to translate everything to English and proceed to use English names for checks
@mobeigi mobeigi added the bug Something isn't working label Jul 28, 2019
@mobeigi mobeigi added this to the 1.0.3 milestone Aug 3, 2019
@mobeigi
Copy link
Owner Author

mobeigi commented Aug 3, 2019

Ended up setting python locale based on users locale and matching day names.
Seems to work quite well with a simple beautiful soup parse (for html codes) and lower() call.

Tested with following locales: en_GB, en_US, es_ES, it_IT, de_DE, sv_SE, bs_BA

@mobeigi mobeigi closed this as completed in eef6458 Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.3
Development

No branches or pull requests
1 participant
@mobeigi