Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer to Peer Code Review #5

Open
AyoubM490 opened this issue Feb 22, 2022 · 0 comments
Open

Peer to Peer Code Review #5

AyoubM490 opened this issue Feb 22, 2022 · 0 comments

Comments

@AyoubM490
Copy link

Things to Highlight:

  • Respected the GitHub flow
  • The Code is Clean from Linting Errors
  • Good use of Local Storage, when we refresh, we have the data persisted
  • You have a good README
    Things to update:
  • After adding a task, be sure to clear the input text from the previous text.
  • Use google Material Icons instead of just plain text
  • Add an add button, so that the user will be able to add tasks from the UI, and not just by pressing enter
  • Use ES6 arrow functions, and include them in Modules instead of plain JS function syntax
  • We suggest that you add an algorithm for checking if the items are duplicated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant