Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make HTML repr for Forward match others #12883

Merged
merged 4 commits into from
Oct 2, 2024
Merged

make HTML repr for Forward match others #12883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da6bf2d
refactor channels HTML repr
drammock Oct 2, 2024
6c3dea4
use channels template in fwd
drammock Oct 2, 2024
95afeb1
make fwd collapsible
drammock Oct 2, 2024
3c76cd6
demo it in docs
drammock Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions mne/html_templates/repr/_channels.html.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,7 @@
{%include 'static/_section_header_row.html.jinja' %}

{% for channel_type, channels in (info | format_channels).items() %}
{% set channel_names_good = channels["good"] | map(attribute='name_html') | join(', ') %}
<tr class="repr-element {{ section_class_name }} {{ collapsed_row_class }}">
<td class="mne-repr-section-toggle"></td>
<td>{{ channel_type }}</td>
<td>
<button class="mne-ch-names-btn sd-sphinx-override sd-btn sd-btn-info sd-text-wrap sd-shadow-sm" onclick="alert('Good {{ channel_type}}:\n\n{{ channel_names_good | safe }}')" title="(Click to open in popup)&#13;&#13;{{ channel_names_good | safe }}">
{{ channels["good"] | length}}
</button>

{% if channels["bad"] %}
{% set channel_names_bad = channels["bad"] | map(attribute='name_html') | join(', ') %}
and <button class="mne-ch-names-btn sd-sphinx-override sd-btn sd-btn-info sd-text-wrap sd-shadow-sm" onclick="alert('Bad {{ channel_type}}:\n\n{{ channel_names_bad | safe }}')" title="(Click to open in popup)&#13;&#13;{{ channel_names_bad | safe }}">
{{ channels["bad"] | length}} bad
</button>
{% endif %}
</td>
</tr>
{% include 'static/_channels.html.jinja' %}
{% endfor %}

<tr class="repr-element {{ section_class_name }} {{ collapsed_row_class }}">
Expand Down
42 changes: 18 additions & 24 deletions mne/html_templates/repr/forward.html.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,29 @@
{%include '_js_and_css.html.jinja' %}

{% set section = "Forward" %}
{% set section_class_name = section | lower | append_uuid %}

{# Collapse content during documentation build. #}
{% if collapsed %}
{% set collapsed_row_class = "mne-repr-collapsed" %}
{% else %}
{% set collapsed_row_class = "" %}
{% endif %}

<table class="table mne-repr-table">
{%include 'static/_section_header_row.html.jinja' %}
{% for channel_type, channels in (info | format_channels).items() %}
{% set channel_names_good = channels["good"] | map(attribute='name_html') | join(', ') %}
<tr class="repr-element {{ section_class_name }} {{ collapsed_row_class }}">
<th>{{ channel_type }}</th>
<td>
<button class="mne-ch-names-btn sd-sphinx-override sd-button sd-btn-info sd-text-wrap sd-shadow-sm"
onclick="alert('Good {{ channel_type}}:\n\n{{ channel_names_good | safe }}')"
title="Show good channel names">
{{ channels["good"] | length}}
</button>

{% if channels["bad"] %}
{% set channel_names_bad = channels["bad"] | map(attribute='name_html') | join(', ') %}
and <button class="mne-ch-names-btn sd-sphinx-override sd-button sd-btn-info sd-text-wrap sd-shadow-sm"
onclick="alert('Bad {{ channel_type}}:\n\n{{ channel_names_bad | safe }}')"
title="Show bad channel names">
{{ channels["bad"] | length}} bad
</button>
{% endif %}
</td>
</tr>
{% include 'static/_channels.html.jinja' %}
{% endfor %}

<tr>
<th>Source space</th>
<tr class="repr-element {{ section_class_name }} {{ collapsed_row_class }}">
<td class="mne-repr-section-toggle"></td>
<td>Source space</td>
<td>{{ source_space_descr }}</td>
</tr>
<tr>
<th>Source orientation</th>
<tr class="repr-element {{ section_class_name }} {{ collapsed_row_class }}">
<td class="mne-repr-section-toggle"></td>
<td>Source orientation</td>
<td>{{ source_orientation }}</td>
</tr>
</table>
17 changes: 17 additions & 0 deletions mne/html_templates/repr/static/_channels.html.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{% set channel_names_good = channels["good"] | map(attribute='name_html') | join(', ') %}
<tr class="repr-element {{ section_class_name }} {{ collapsed_row_class }}">
<td class="mne-repr-section-toggle"></td>
<td>{{ channel_type }}</td>
<td>
<button class="mne-ch-names-btn sd-sphinx-override sd-btn sd-btn-info sd-text-wrap sd-shadow-sm" onclick="alert('Good {{ channel_type}}:\n\n{{ channel_names_good | safe }}')" title="(Click to open in popup)&#13;&#13;{{ channel_names_good | safe }}">
{{ channels["good"] | length}}
</button>

{% if channels["bad"] %}
{% set channel_names_bad = channels["bad"] | map(attribute='name_html') | join(', ') %}
and <button class="mne-ch-names-btn sd-sphinx-override sd-btn sd-btn-info sd-text-wrap sd-shadow-sm" onclick="alert('Bad {{ channel_type}}:\n\n{{ channel_names_bad | safe }}')" title="(Click to open in popup)&#13;&#13;{{ channel_names_bad | safe }}">
{{ channels["bad"] | length}} bad
</button>
{% endif %}
</td>
</tr>
2 changes: 1 addition & 1 deletion tutorials/forward/35_eeg_no_mri.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
fwd = mne.make_forward_solution(
raw.info, trans=trans, src=src, bem=bem, eeg=True, mindist=5.0, n_jobs=None
)
print(fwd)
fwd

##############################################################################
# From here on, standard inverse imaging methods can be used!
Expand Down
Loading