-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split off simulation code into separate package #12980
Comments
one possible downside to the "spinoff" approach that I've just thought of, is the risk of losing git history (edit: and hence contributor credit) for the existing code. I think there's probably a way to preserve it, via something like:
|
+1, glad someone is working on simulation! |
Thank you, @drammock! Tagging @minajamshidi and @astudenova to keep them in the loop. |
+1 to spin off under |
+1 for spin off with some |
Go for it 👍 |
Also 👍 for spin off! |
+1 from me, too. Really excited about the cool options that @ctrltz, @minajamshidi, and @astudenova support in MEEGsim! 😍 |
+1 supporting simulation would help so much research in this space. |
+1 too. We could even start thinking into adding ML based generative models. There is a bunch of cool works in this space eg https://www.biorxiv.org/content/10.1101/2023.08.23.554148v1 |
OK thanks everyone for weighing in. I'll start working on the deprecation + spin-off this week. I'll leave this open, but convert the title to be normative, so we can close it when the spin-off is complete. |
Hi @mne-tools/mne-python-steering-committee
@ctrltz and colleagues have been doing some work on simulating MNE objects (above and beyond what we currently support), in the new https://github.com/ctrltz/meegsim package. They have expressed interest in incorporating their work into MNE-Python, and after a few discussions with @larsoner @agramfort and @britta-wstnr we've settled on a tentative plan to "spin off" our existing simulation code into a new package (
mne-simulation
or so) similar to what was done for connectivity a few years ago, and then give @ctrltz and colleagues write-access to that repo so they can add their code and also have a much smaller/faster test/CI suite. Existing simulation code would be deprecated in MNE-Python release 1.9 and removed in 1.10.This issue is your chance to weigh in on whether you think it best to:
The text was updated successfully, but these errors were encountered: