Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: TSPCA or regress_artifact #832

Closed
larsoner opened this issue Jan 16, 2024 · 7 comments · Fixed by #837
Closed

ENH: TSPCA or regress_artifact #832

larsoner opened this issue Jan 16, 2024 · 7 comments · Fixed by #837

Comments

@larsoner
Copy link
Member

We currently don't offer any (?) reference-sensor-based preprocessing. meegkit has TSPCA for this. I haven't used it much but some collaborators with a KIT system have had good results. Any objection to me adding it as a step?

As part of this, I'd need to find a dataset that has reference sensors... not sure if we have any so far.

@hoechenberger
Copy link
Member

I'm not familiar with this method, but I don't have any objections to adding it!

@agramfort
Copy link
Member

agramfort commented Jan 16, 2024 via email

@larsoner
Copy link
Member Author

We had some discussion of doing that in mne-tools/mne-python#7170 (comment) and after some additional discussion in mne-tools/mne-python#9302 (comment) about mne-incubator vs meegkit nothing came of it.

What's the issue with making meegkit an optional dependency if you use only tsPCA for example? It seems like we should leverage existing implementations when possible. And if/when we eventually move tsPCA somewhere else, then we update the dependency. Or are you worried it's not fully vetted/tested etc.?

@agramfort
Copy link
Member

agramfort commented Jan 17, 2024 via email

@larsoner
Copy link
Member Author

Okay it looks like for at least one dataset mne.preprocessing.regress_artifact provides very similar (identical to a quick eye check) performance on one dataset.

WDYT about adding a regress_artifact = dict(picks=None, picks_artifact=None) for example? For my dataset that would be dict(picks="meg", picks_artifact=["MISC 001", "MISC 002", "MISC 003"]) for example. I think it would be flexible enough to allow regressing other artifacts people have recorded, too (e.g., EOG if they want rather than using SSP).

@agramfort
Copy link
Member

you need adding an option to support mne.preprocessing.regress_artifact here?

@larsoner
Copy link
Member Author

Yeah that's what I'm thinking

@larsoner larsoner changed the title ENH: TSPCA ENH: TSPCA or regress_artifact Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants