Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ability to complete a payment request #68

Open
AdamWHuffman opened this issue Apr 3, 2022 · 4 comments
Open

Allow ability to complete a payment request #68

AdamWHuffman opened this issue Apr 3, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@AdamWHuffman
Copy link

Currently see that cancel and get are options for payments. I fam unsure if the api supports a PUT complete for example, but that would be super useful.
Unsure how how to discover more actions as Venmo's api isn't documented anywhere to my understanding.

@AdamWHuffman AdamWHuffman changed the title Allow ability to complete a payment Allow ability to complete a payment request Apr 3, 2022
@mmohades
Copy link
Owner

mmohades commented Apr 5, 2022

I'll have to look into it. Do you need this feature?

@mmohades mmohades added the enhancement New feature or request label Apr 5, 2022
@AdamWHuffman
Copy link
Author

Would be super helpful. I have a Venmo manager I made that makes use of this project that can send requests and it would be great to add the ability to completing them.

I know the API docs you have support the ability to "cancel", but I've been trying a bunch of other things like "complete" or "settle" but haven't had any luck yet. Not sure if you know how to scrape it for more API routes/actions.

@Davis8483
Copy link

Davis8483 commented Mar 1, 2024

Any update, I need the same feature for my project. The only workaround I can think of would be to detect a payment and cancel it. Then use the username to send a request, and detect when that request is accepted. However, that would be very janky for the end user.

(Edit: I thought when sending a venmo payment the recipient had to accept it, so please ignore the rambling about the janky solution)

@Davis8483
Copy link

Venmo Docs - Complete a Payment Request
The docs list the valid actions as approve, deny, or cancel

Now, if we trace back the cancel_payment() method in the python library we find that it calls self.__update_payment(action="cancel", payment_id=payment_id)

So one would assume you could call this instead with the approve or deny action.

self.venmo = Client(access_token="Your access token")

// grab first payment in the list
my_payment = self.venmo.payment.get_charge_payments(limit=1)[0]

// approve the payment
self.venmo.payment.__update_payment("approve", my_payment)

note: this code is untested, just throwing around ideas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants