unit test for the new homepage #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| title: "", | ||
| publishedDate: new Date(), | ||
| link: "https://blog.webmaker.org" | ||
| }] | ||
| } |
There was a problem hiding this comment.
have to set some initial values so we don't run into validation / parsing errors during the initial render
There was a problem hiding this comment.
cool, this will be nice for non-JS users too maybe, so that at least there will be a link to the blog they can click on?
mmmavis
force-pushed
the
issue-856-new-homepage-test
branch
from
7506c04 to
52f6fd6
Compare
| @@ -1,5 +1,5 @@ | |||
| var FAKE_POSTS = { | |||
| "featuredPosts": { | |||
| "featuredPost": { | |||
There was a problem hiding this comment.
This was referenced May 28, 2015
mmmavis
pushed a commit
that referenced
this pull request
Mar 2, 2016
Switch to use newsletters signup on ET/Basket instead (goodbye BSD)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP...