From 5152a87c4bc44e8b0d009995cb69c8a0533b1010 Mon Sep 17 00:00:00 2001 From: Atul Varma Date: Wed, 27 May 2015 17:45:13 -0400 Subject: [PATCH] Add stub-blog-feed-loader.js and use it for now. --- lib/blog-feed-loader.js | 67 +-------------------------- package.json | 1 - pages/home.jsx | 22 +++++---- test/browser/stub-blog-feed-loader.js | 30 ++++++++++++ 4 files changed, 46 insertions(+), 74 deletions(-) create mode 100644 test/browser/stub-blog-feed-loader.js diff --git a/lib/blog-feed-loader.js b/lib/blog-feed-loader.js index 286a6021e..4dd0b93b5 100644 --- a/lib/blog-feed-loader.js +++ b/lib/blog-feed-loader.js @@ -1,65 +1,2 @@ -var sanitizeHtml = require('sanitize-html'); - -function loadGoogleAPI(window, callback) { - if (window.google) { - return process.nextTick(callback); - } - var head = document.getElementsByTagName('head')[0]; - var gScript = document.createElement('script'); - gScript.setAttribute('src', 'https://www.google.com/jsapi'); - gScript.onload = callback; - head.appendChild(gScript); -}; - -function getBlogFeeds(feedUrl, callback) { - if (window.google) { - var google = window.google; - google.load('feeds', '1', { - callback: function() { - var feed = new google.feeds.Feed(feedUrl); - feed.load(function(result) { - callback(formatBlogFeeds(result.feed)); - }); - } - }); - } -} - -function formatBlogFeeds(feeds) { - var featured = feeds.entries[0]; - var latestPosts = []; - var post; - for (var i = 1; i < 4; i++) { - post = feeds.entries[i]; - latestPosts.push({ - title: post.title, - publishedDate: post.publishedDate, - link: post.link - }); - } - return { - featuredPostData: { - title: featured.title, - author: featured.author, - publishedDate: featured.publishedDate, - contentSnippet: sanitizeHtml(featured.content, { - allowedTags: [] - }).split(' ').slice(0, 70).join(' ') + '...', - link: post.link - }, - latestPostsData: latestPosts - }; -} - -var loadBlogFeed = function(requestedComp, window, feedUrl, callback) { - loadGoogleAPI(window, function() { - if (requestedComp.isMounted()) { - getBlogFeeds(feedUrl, function(result) { - callback(result); - }); - } - }); -}; - -module.exports = loadBlogFeed; - +// TODO: Replace this with a real implementation. +module.exports = require('../test/browser/stub-blog-feed-loader'); diff --git a/package.json b/package.json index 94211dea0..ea6a9c109 100644 --- a/package.json +++ b/package.json @@ -38,7 +38,6 @@ "react-ga": "^1.0.12", "react-router": "^0.13.2", "react-select": "0.4.6", - "sanitize-html": "^1.6.1", "should": "^5.1.0", "simplecrawler": "^0.5.2", "source-map-support": "^0.2.10", diff --git a/pages/home.jsx b/pages/home.jsx index 2be0aa9bb..77be79f30 100644 --- a/pages/home.jsx +++ b/pages/home.jsx @@ -2,7 +2,6 @@ var React = require('react'); var Router = require('react-router'); var Link = Router.Link; var moment = require('moment'); -var sanitizeHtml = require('sanitize-html'); var HeroUnit = require('../components/hero-unit.jsx'); var Blockquote = require('../components/blockquote.jsx'); @@ -14,7 +13,7 @@ var IconButton = require('../components/icon-button.jsx'); var config = require('../lib/config'); -var blogFeedLoader = require('../lib/blog-feed-loader'); +var loadBlogPosts = require('../lib/blog-feed-loader'); var CaseStudies = React.createClass({ render: function() { @@ -88,6 +87,11 @@ var LatestPosts = React.createClass({ }); var BlogSection = React.createClass({ + getDefaultProps: function() { + return { + loadBlogPosts: loadBlogPosts + }; + }, getInitialState: function() { return { featuredPostData: { @@ -101,13 +105,15 @@ var BlogSection = React.createClass({ } }, componentDidMount: function() { - var self = this; - blogFeedLoader(this, window, "https://blog.webmaker.org/tag/teachtheweb/feed", function(data) { - self.setState({ - featuredPostData: data.featuredPostData, - latestPostsData: data.latestPostsData + this.props.loadBlogPosts(function(data) { + if (!this.isMounted()) { + return; + } + this.setState({ + featuredPostData: data.featuredPosts, + latestPostsData: data.latestPosts }); - }); + }.bind(this)); }, render: function() { return ( diff --git a/test/browser/stub-blog-feed-loader.js b/test/browser/stub-blog-feed-loader.js new file mode 100644 index 000000000..2d76c03e6 --- /dev/null +++ b/test/browser/stub-blog-feed-loader.js @@ -0,0 +1,30 @@ +var FAKE_POSTS = { + "featuredPosts": { + "title": "What’s next for Thimble?", + "author": "Hannah Kane", + "publishedDate": "Tue, 12 May 2015 10:47:33 -0700", + "contentSnippet": "Last week we announced that Thimble will soon be moving over to our new site for people who teach the web, teach.mozilla.org. We also shared that Professor David Humphrey and a team of students from Seneca College have been working to make Thimble an even more powerful teaching, learning, and development tool.\nWe wanted to follow up with more specifics about what you can expect from the new Thimble:\n\nOver the next...", + "link": "https://blog.webmaker.org/whats-next-for-thimble" + }, + "latestPosts": [ + { + "title": "What’s next for Webmaker tools", + "publishedDate": "Mon, 04 May 2015 11:53:23 -0700", + "link": "https://blog.webmaker.org/whats-next-for-webmaker-tools" + }, + { + "title": "Understanding Web Literacy within the Web Journey", + "publishedDate": "Tue, 21 Apr 2015 08:04:56 -0700", + "link": "https://blog.webmaker.org/understanding-web-literacy-within-the-web-journey" + }, + { + "title": "Learning Through Making: The Best Kind of Education", + "publishedDate": "Thu, 16 Apr 2015 12:04:55 -0700", + "link": "https://blog.webmaker.org/learning-through-making-the-best-kind-of-education" + } + ] +}; + +module.exports = function(cb) { + process.nextTick(cb.bind(null, FAKE_POSTS)); +};