Fix wrong first_page_path
because of hard-coded page:num
#3778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix.
Summary
In code
assign first_page_path = ... | replace: 'page:num', '' | ...
,page:num
is hard-coded. So ifsite.paginate_path
doesn't ends withpage:num/
orpage:num
,first_page_path
will get a wrong value.The PR tries parsing the last part from
site.paginate_path
, instead of using a hard-codedpage:num
.Context
The same issue with: #2431 (comment)
The author of #2413 addressed the issue with Paginate V2. But I'm using GitHub Actions and only V1 is supported so I have to make the fix.
BTW, I'm new to Liquid and
"/blog/:num/" | split: "/"
returns["", "blog", ":num"]
, instead of["", "blog", ":num", ""]
as I expected. Weird... Shopify/liquid#862