Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking Author avatar and name to site root #1331

Closed
2 of 5 tasks
shredtechular opened this issue Nov 4, 2017 · 2 comments
Closed
2 of 5 tasks

Linking Author avatar and name to site root #1331

shredtechular opened this issue Nov 4, 2017 · 2 comments

Comments

@shredtechular
Copy link
Contributor

  • This is a question about using the theme.
  • This is a feature request.
  • I believe this to be a bug with the theme.
    • I have updated all gems with bundle update.
    • I have tested locally with bundle exec jekyll build.

Feature Request Question

In your docs, you mentioned when in doubt on contributing to ask first, so this is just a question if you would want to consider a feature pull request for making the author avatar and name in the sidebar nav linkable -- for example, I have a customer interested in making those link back to the site root for users.

This might fall into the customization bucket that we should do this in our child of your theme, but wasn't sure if maybe you thought this might be desired by a number of your other users to consider a pull request for it?

Thanks!

@mmistakes
Copy link
Owner

I think this might fall in the customization bucket. I'm not sure if this could be done "clean" so that it is easy to turn off/on for those who don't want it.

What makes it complicated as not everyone who'd want the author avatar and name to link back somewhere, will want it to go to the site's root. In the cases where blogs support multiple authors this would be problematic.

This is why I've included the website uri key for the author sidebar, to provide a way to link back to the author's site.

@stale
Copy link

stale bot commented Dec 5, 2017

This issue has been automatically marked as stale because it has not had recent activity.

If this is a bug and you can still reproduce this error on the master branch, please reply with any additional information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants