Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken in Craft 3.7.46. #17

Closed
parthi-me opened this issue Jul 1, 2022 · 8 comments
Closed

Broken in Craft 3.7.46. #17

parthi-me opened this issue Jul 1, 2022 · 8 comments
Labels
bug Something isn't working compatibility

Comments

@parthi-me
Copy link

parthi-me commented Jul 1, 2022

Updated to Latest Craft CMS version 3.7.46 from 3.7.45.2 and it's broken the reasons plugin functionality. I can't see any obvious errors appearing, the fields with conditional rules are applied but they just don't appear in the entries.

@joshuarichard
Copy link

Also experiencing this. Don't see logs on the server or the client that would give clues to the issue(s).

CraftCMS => 3.7.46
mmikkel/reasons => 2.3.0.1

@mmikkel
Copy link
Owner

mmikkel commented Jul 1, 2022

Hi, thanks for reporting this. I'll have a look at it ASAP.

@joshuarichard
Copy link

Thanks a lot @mmikkel. Let me know if you need any version or implementation details from us.

@mmikkel
Copy link
Owner

mmikkel commented Jul 1, 2022

@parthi-me @joshuarichard I'm not able to reproduce this, so I need more info:

  • Any JavaScript errors in your browser's dev tools console
  • Browser and OS version
  • PHP version
  • Database version
  • Other plugins installed
  • Multisite?
  • Description of a specific conditional that isn't working (element type, toggle field type, target field type, and the rule)

I'm also not seeing anything in the v3 changelog for 3.7.45.2 -> 3.7.46 that immediately jumps out as something that'd break Reasons.

If either of you could DM me (@mmikkel) on the Craft Discord with a database dump, composer.json and composer.lock file I can also try to dig further to reproduce with that.

@mmikkel
Copy link
Owner

mmikkel commented Jul 1, 2022

Also, check if Reasons' JS is even loading by looking in your browser dev tools' Networks panel. It should have an entry for a file called render.js:

CleanShot 2022-07-01 at 21 39 16@2x

@parthi-me
Copy link
Author

Hi @mmikkel , I see the dropdown field encryption is enabled in the latest Craft CMS update. This could be the reason for the above issue. I verified that before the update dropdown values are not encoded which you directly used to check against the values and displayed the respective fields. But as the values are encoded now we may need to decode and verify the values.

3.7.46 - Added craft\fields\BaseOptionsField::encodeValue().

@mmikkel
Copy link
Owner

mmikkel commented Jul 4, 2022

@parthi-me Thanks, you're absolutely correct.

So it's specifically option toggle fields (i.e. dropdowns, radio buttons and checkboxes) that are broken, on 3.7.46. I'll look into a fix ASAP.

@mmikkel mmikkel added bug Something isn't working compatibility and removed cant reproduce labels Jul 4, 2022
@mmikkel
Copy link
Owner

mmikkel commented Jul 4, 2022

Should be resolved in Reasons 2.3.1. Thanks!

@mmikkel mmikkel closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility
Projects
None yet
Development

No branches or pull requests

3 participants