Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: swap ios button style, closes #689 #712

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix: swap ios button style, closes #689 #712

merged 1 commit into from
Jun 27, 2023

Conversation

ddikodroid
Copy link
Contributor

Overview

Swap the button style on iOS as suggested on #689

Test Plan

The order of style on cancel button is the same as confirm button.

@mmazzarolo
Copy link
Owner

thanks @ddikodroid !

@mmazzarolo mmazzarolo merged commit 759600e into mmazzarolo:master Jun 27, 2023
github-actions bot pushed a commit that referenced this pull request Jun 27, 2023
@semantic-release-bot
chore(release): 17.0.0 [skip ci]
a8bb4ca 
# [17.0.0](v16.0.0...v17.0.0) (2023-06-27)

### Bug Fixes

* swap `CancelButton`'s `themedButtonStyle` style order, closes [#689](#689) ([#712](#712)) ([759600e](759600e))

### BREAKING CHANGES

* This is a light breaking change since it might break the UI of folks relying on the previous (wrong) order
@github-actions
Copy link

🎉 This PR is included in version 17.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddikodroid @mmazzarolo