Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected focus object name and URL caused the add-on to not work in some cases. #2

Open
cary-rowen opened this issue Jan 17, 2024 · 2 comments

Comments

@cary-rowen
Copy link

Hi Tony,

I mentioned before in groups.io that the plugin didn't work for me.
I did some debugging and found the exact cause of the issue.

URL mismatch in some cases:

The URL of my document is: https://docs.google.com/document/d/1-QJdda6_hzISQYTM600LtOpzw8Jy5SQy8bm2PqBjCLA/edit?usp=sharing

However, at some point, the last character in 'docs.google.com/document/d' may also become 'u'. I still don't know what 'd' and 'u' mean.

Just for debugging, I changed the matching expression on line 191 of the script into the following form:
if not url.startswith("https://docs.google.com/document/"):

focus object name doesn't match

I'm using the Chinese google docs: the focus name has been localized to Chinese.
Actually '文档内容' rather than 'document content'.

After I fixed these two things, the add-on worked as expected.

In addition, we should probably also mention in the add-on that the shortcut key to start NVDA should be changed to other shortcut keys, although Google has already done this in the Google docs documentation.

Best
Cary

@mltony
Copy link
Owner

mltony commented Jan 17, 2024

Thansk for reporting this. I just pushed a few commits to the main branch - would you like to test if that solves your issue?

@cary-rowen
Copy link
Author

Hi @mltony

Yes, the latest commit worked for me.

There is a typo in the last line of the document:

Selection commands, such as Shift+Arrows are not supported at this time. Please switch to forms mode for selection.

Did you mean "focus mode"?

Also, I've found that if a document doesn't contain a link and I try to navigate to the next link it causes an error in google docs.

If I press ctrl+alt+n,ctrl+alt+k alone, no error will occur.

If more debug logging is needed, I'll do it.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants