Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider use of internal ref() function #418

Closed
jemus42 opened this issue Sep 10, 2022 · 5 comments
Closed

Reconsider use of internal ref() function #418

jemus42 opened this issue Sep 10, 2022 · 5 comments

Comments

@jemus42
Copy link
Member

jemus42 commented Sep 10, 2022

In some cases like `r ref("resample()")`, the resulting output is functionally identical to the output that downlit already generates when `resample()` is encountered in the text.
I'm wondering if the overhead is worth it, given that we're working around/on top of downlit for questionable benefit.

The ref() helper provides more functionality, yes, but in the simplest case I'd argue it's not worth it.

@mllg
Copy link
Member

mllg commented Sep 10, 2022

I haven't checked what's happening with the current version of quarto/downlit, but in the past the inline code chunks (using a single backtick) were not processed/linked. Did that change?

@jemus42
Copy link
Member Author

jemus42 commented Sep 10, 2022

As far as I can tell, yes. Tried it in a local make serve and the main difference is that downlit'd links aren't blue and underlined, but they're still links.

Not sure when you checked the last time, but quarto integrates downlit but RMarkdown/bookdown didn't (out of the box). Maybe the appropriate option wasn't set before?

@mllg
Copy link
Member

mllg commented Sep 14, 2022

AFAICT we would have two different styles of links and R6 objects are not linked (r-lib/downlit#140). Maybe we just stick to ref() and wait for downlit to improve?

@jemus42
Copy link
Member Author

jemus42 commented Sep 14, 2022

Ah, fair point. I was hoping we could spare ourselves some homebrewery, but I agree.

@pat-s
Copy link
Member

pat-s commented Sep 14, 2022

I tried that during the move to quarto already and I think we should still with our own ref(). Thanks for double-checking though!

@pat-s pat-s closed this as completed Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants