Benchmark scoring fix. #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpietri
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
wpietri
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
wpietri
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
dhosterman
approved these changes
Dec 5, 2024
bkorycki
approved these changes
Dec 5, 2024
rogthefrog
approved these changes
Dec 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem where benchmark scoring combines official and practice prompts for the standard. Now official and practice each have their own standards.
This shifts responsibility for knowing a benchmark's standard to the BenchmarkDefinition, in parallel with how it works for hazards. Between this and the 0.5 legacy stuff this leaves a lot of dead or deprecated code, but I didn't want to mess with too much for an emergency fix.