Move partials to macros and tests

[mkly]

• Move partials to macros for testability
• Add tests for components and pages

[github-actions]

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

[mkly]

Just some quick tests/shuffling around to make it a bit quicker for me to dig into this stuff.

[wpietri]

Looks good to me, but could you say a bit more about the kind of programmer error that's motivating those particular new tests?

[mkly]

Looks good to me, but could you say a bit more about the kind of programmer error that's motivating those particular new tests?

I find it a bit challenging as it stands to know where things are changing where edits are made. There is global scope and components and I'm trying to include some testing and small refactors to help prevent regressions as I am about to start making some additions based on an earlier discussion I had this morning.

[dhosterman]

This all looks good to me, though I worry that things are going to be in a lot of flux and that these tests will become outdated very quickly. In particular, things like "66% safe responses" are very tenuous.

But if these are helpful to your comfort with refactoring, I'm all for it!

[mkly]

things like "66% safe responses" are very tenuous.

Indeed. It is more scaffolding that anything else. Those will get updated very soon to more meaningful values as I get a better understanding of what is going on with the code. I just needed to get something initially up and didn't want to waste a lot of time trying to be perfect. Thanks for taking a look.