Add link functions and view embed flag #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add link functions and view embed flag This allows for running `--view-embed` to generate a "emdedded view" html. The main thing this is currently doing is simply not appending `.html` to links. There will be more changes needed and the generic term of `view-embed` vs doing `remove-extention` was in anticipation of those other changes This option defaults to false so users of the tool that are running their own reports will not need to be aware of it as the default will simply create the local html test report output. new help text: ``` Usage: run.py benchmark [OPTIONS] run the standard benchmark Options: -o, --output-dir DIRECTORY -m, --max-instances INTEGER --debug --web-only --view-embed Render the HTML to be emdedded in another view --help Show this message and exit. ```
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
Need to clean up some tests with jinja. Closing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for running
--view-embedto generate a "emdedded view" html. The main thing this is currently doing is simply not appending.htmlto links. There will be more changes needed and the generic term ofview-embedvs doingremove-extentionwas in anticipation of those other changesThis option defaults to false so users of the tool that are running their own reports will not need to be aware of it as the default will simply create the local html test report output.
new help text: