-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Android and Flutter makefiles #112
Comments
@mcharleb, is there a particular reason why we use |
Top level make files should be minimal, include app-specific make files from the subdirs. |
If the Android app will be deprecated in favor of Flutter app. I think it's best not to merge them. Just move the Makefile for Android into |
I think that we should do the following in context of this task:
I also wanted to change the way we handle docker. Now there are just monstrous commands for everything in docker. I want to split each command (ones that we have now and ones that we will add in the future) into 2 parts: the And we should probably create a bunch more issues which would be linked to this one, and this one should be used just for tracking the status of the refactoring. |
Another thing to note is that while the Android app itself will be deprecated, at least half of the configs and build commands (which were previously used for the Android app) are actually for backends, which are not going to be deprecated any time soon. |
I would just copy those configs and command to some place outside the |
@anhappdev, which exact common resources are you talking about? |
Those you mentioned earlier:
|
We need to have uniform integrated makefiles across the repo.
Makefiles from the Flutter app repo don't match the style used in this repo, so they need to be significantly rewritten.
Parent issue: #92
The text was updated successfully, but these errors were encountered: