Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Android and Flutter makefiles #112

Closed
d-uzlov opened this issue Nov 2, 2021 · 9 comments · Fixed by #174
Closed

Merge Android and Flutter makefiles #112

d-uzlov opened this issue Nov 2, 2021 · 9 comments · Fixed by #174
Assignees

Comments

@d-uzlov
Copy link
Contributor

d-uzlov commented Nov 2, 2021

We need to have uniform integrated makefiles across the repo.
Makefiles from the Flutter app repo don't match the style used in this repo, so they need to be significantly rewritten.

Parent issue: #92

@d-uzlov d-uzlov self-assigned this Nov 2, 2021
@d-uzlov
Copy link
Contributor Author

d-uzlov commented Nov 15, 2021

@mcharleb, is there a particular reason why we use @ everywhere in all makefiles to suppress the command echoing?

@relja128
Copy link
Contributor

Top level make files should be minimal, include app-specific make files from the subdirs.

@relja128 relja128 added this to the 211130 - November 2021 milestone Nov 16, 2021
@mcharleb mcharleb linked a pull request Nov 17, 2021 that will close this issue
@anhappdev
Copy link
Collaborator

If the Android app will be deprecated in favor of Flutter app. I think it's best not to merge them. Just move the Makefile for Android into android folder.

@d-uzlov
Copy link
Contributor Author

d-uzlov commented Nov 24, 2021

I think that we should do the following in context of this task:

  1. Pull make targets for the Flutter app to the repository root (and refactor them in the process)
  2. Integrate all backends with the Flutter app
  3. Add commands to build Flutter app with docker
  4. And because all this would be too much for one makefile: refactor our root make file, moving Android-app-related stuff to the /android directory.

I also wanted to change the way we handle docker. Now there are just monstrous commands for everything in docker. I want to split each command (ones that we have now and ones that we will add in the future) into 2 parts: the make command itself, which builds what is needed locally, and make docker/command, which mounts docker container and runs make command inside.

And we should probably create a bunch more issues which would be linked to this one, and this one should be used just for tracking the status of the refactoring.

@d-uzlov
Copy link
Contributor Author

d-uzlov commented Nov 24, 2021

If the Android app will be deprecated in favor of Flutter app

Another thing to note is that while the Android app itself will be deprecated, at least half of the configs and build commands (which were previously used for the Android app) are actually for backends, which are not going to be deprecated any time soon.

@anhappdev
Copy link
Collaborator

Another thing to note is that while the Android app itself will be deprecated, at least half of the configs and build commands (which were previously used for the Android app) are actually for backends, which are not going to be deprecated any time soon.

I would just copy those configs and command to some place outside the android folder. We should not have dependency on deprecated code. Sometime in the feature we will probably mark the android folder as deprecated and do not want to touch it anymore.

@anhappdev
Copy link
Collaborator

anhappdev commented Nov 30, 2021

@d-uzlov I think we can do the first point of #153 in this issue or prepare for it.

@d-uzlov
Copy link
Contributor Author

d-uzlov commented Nov 30, 2021

@anhappdev, which exact common resources are you talking about?

@anhappdev
Copy link
Collaborator

which exact common resources are you talking about?

Those you mentioned earlier:

Another thing to note is that while the Android app itself will be deprecated, at least half of the configs and build commands (which were previously used for the Android app) are actually for backends, which are not going to be deprecated any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment