Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal file-download CM script #621

Closed
arjunsuresh opened this issue Jan 12, 2023 · 4 comments
Closed

Universal file-download CM script #621

arjunsuresh opened this issue Jan 12, 2023 · 4 comments

Comments

@arjunsuresh
Copy link
Contributor

We currently have a download function in CM which can download any file similar to wget. If the downloaded file is a zip or tar file, we currently extract them in individual customize.py files. It would be cleaner if we make a download-file cm script which internally calls this download function and does any needed extraction of the downloaded files. This download-file cm script can then be added as a pre_hook_deps to other CM scripts replacing the current redundant codes there.

@gfursin
Copy link
Contributor

gfursin commented Jan 15, 2023

I agree. Just let's make sure that it's portable across all platforms including Windows!
Thank you!

@arjunsuresh
Copy link
Contributor Author

Hi @gfursin , I have made a prototype for this here. This is expected to handle all downloads and extractions with checksum checks for validation so that users do not face any issue due to broken downloads. But to make this work on windows we probably need to redo all the commands - they are not a lot though.

@gfursin
Copy link
Contributor

gfursin commented May 12, 2023

It will be very useful! Thank you very much @arjunsuresh . But we should support Windows too ;) - I can check it at some point ...

@gfursin
Copy link
Contributor

gfursin commented Jan 27, 2024

I added support on Windows and it seems to be working fine now. I close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants