-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Universal file-download CM script #621
Comments
I agree. Just let's make sure that it's portable across all platforms including Windows! |
Hi @gfursin , I have made a prototype for this here. This is expected to handle all downloads and extractions with checksum checks for validation so that users do not face any issue due to broken downloads. But to make this work on windows we probably need to redo all the commands - they are not a lot though. |
It will be very useful! Thank you very much @arjunsuresh . But we should support Windows too ;) - I can check it at some point ... |
I added support on Windows and it seems to be working fine now. I close this ticket. |
We currently have a download function in CM which can download any file similar to wget. If the downloaded file is a zip or tar file, we currently extract them in individual
customize.py
files. It would be cleaner if we make adownload-file
cm script which internally calls this download function and does any needed extraction of the downloaded files. Thisdownload-file
cm script can then be added as apre_hook_deps
to other CM scripts replacing the current redundant codes there.The text was updated successfully, but these errors were encountered: