Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default is_cpu_op value causes the COMM node to be skipped by the Workload layer. #144

Open
zbceric opened this issue Aug 1, 2024 · 3 comments

Comments

@zbceric
Copy link

zbceric commented Aug 1, 2024

I converted ASTRA-sim 1.0 text input files Resnet50_DataParallel.txt into Chakra traces. However, I observed that the COMM node was skipped by the workload layer of ASTRA-sim. This means that ASTRA-sim only output the time consumed by computation, without considering communication.

This issue was caused by the text converter not setting the is_cpu_op attribute of the COMM node to false. The default value of true causes the workload to skip the node, leading to the anomaly as shown in the following code (Workload.cc):

else if (
        node->is_cpu_op() ||
        (!node->is_cpu_op() && node->type() == ChakraNodeType::COMP_NODE)) {
      if ((node->runtime() == 0) && (node->num_ops() == 0)) {
        skip_invalid(node);
      }
@srinivas212
Copy link
Contributor

@JoongunPark do you know anyone supporting text converter?

@srinivas212
Copy link
Contributor

@zbceric if you post a PR we can review / accept. Thanks!

@JoongunPark
Copy link
Contributor

Sorry for late notice the tag. The problem stems from default value (true) for is_cpu_op.
The above PR will solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants