Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chakra ETNode Comm Size Read Error #136

Open
zzudongxiang opened this issue Jul 18, 2024 · 1 comment
Open

Chakra ETNode Comm Size Read Error #136

zzudongxiang opened this issue Jul 18, 2024 · 1 comment

Comments

@zzudongxiang
Copy link

Describe the Bug

When calling the et_feeder_node->comm_size() method of ETFeederNode, it is found that the read comm size is 0, but the expected result should not be 0.

After investigation, the acquisition failed because the type obtained in src/feeder/et_feeder_node.cpp:28 was attr.int64_val() instead of attr.uint64_val(). it causes the method to return a result of 0

// in src/feeder/et_feeder_node.cpp:28
ETFeederNode::ETFeederNode(std::shared_ptr<ChakraProtoMsg::Node> node) {
...
    } else if (attr_name == "comm_size") {
      this->comm_size_ = attr.int64_val(); // attr.uint64_val() method should be used here
...
}

Looking forward to fixing this bug and checking if there are similar issues elsewhere.

@srinivas212
Copy link
Contributor

@zzudongxiang thanks for reporting the issue. Can you file a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants